cms-nanoAOD / cmssw

CMS NanoAOD software integration repository
http://cms-sw.github.io/
Apache License 2.0
3 stars 10 forks source link

BadPFMuonDzFilter removed by mistake + fix the nanoFlag "Flag_METFilters" #575

Open mariadalfonso opened 3 years ago

mariadalfonso commented 3 years ago

discussed here https://hypernews.cern.ch/HyperNews/CMS/get/JetMET/2113.html problem introduced here for the ULminiV2

https://github.com/cms-sw/cmssw/pull/31087

lathomas commented 3 years ago

Hello. Just to clarify because there are several things:

mariadalfonso commented 3 years ago

@lathomas we should profit to check that all the flags are there;

https://cms-nanoaod-integration.web.cern.ch/integration/cms-swmaster/mc106Xul16_doc.html#Flag

also the Flag_METFiltersis broken, can we fix it ? https://twiki.cern.ch/twiki/bin/view/CMS/MissingETOptionalFiltersRun2#Analysis_Recommendations_for_ana

lathomas commented 3 years ago

Hello, I can confirm that when BadPFMuonDzFilter is present in MINIAOD (which is the case for MINIAOD v2 but not v1), the corresponding bool is saved in NANOAOD. In other words, the bool will be there for NanoV9 (but is absent from V8)

gouskos commented 3 years ago

Thanks @lathomas

alkaloge commented 2 years ago

It actually seems that there must be also nAODv9 MC datasets that the BadPFMuonDzFilter is missing like this one /WJetsToLNu_HT-70To100_TuneCP5_13TeV-madgraphMLM-pythia8/RunIISummer20UL18NanoAODv9-106X_upgrade2018_realistic_v16_L1v1-v1/NANOAODSIM

mariadalfonso commented 1 year ago

@alkaloge and @lathomas

this seems easy to fix for te early run3 nano. Can you have a look and make a PR ?

vlimant commented 1 year ago

closing the loops : @alkaloge and @lathomas can we consider this past history ?