search

cms-nanoAOD / nanoAOD-tools

Tools for working with NanoAOD (requiring only python + root, not CMSSW)
42 stars 328 forks source link

Should jetRecalib.py ever be used? #231

Open adewit opened 4 years ago

adewit commented 4 years ago

In the modules/jme subdirectory there are several tools that appear to do more or less the same thing. I think the syntax from the bottom of jetmetHelperRun2.py should be used (experts can correct me if wrong); if so shouldn't jetRecalib.py (https://github.com/cms-nanoAOD/nanoAOD-tools/blob/master/python/postprocessing/modules/jme/jetRecalib.py ) simply be deleted to avoid people using this (and picking up old JECs unintentionally?)

adewit commented 4 years ago

(The same applies for the lambda module definitions in jetmetUncertainties - if they are not to be used probably best to remove?)

danbarto commented 4 years ago

I agree, we should clear out the JME related tools. Yes, jetmetHelperRun2 is the recommended tool to use the latest developments and corrections.