search

cms-opendata-analyses / PhysObjectExtractorTool

This repository has working code examples (snippets) on how to access different physics objects in the context of CMSSW software.
6 stars 36 forks source link

Photon isos all zero in Muon data? #46

Closed jmhogan closed 2 years ago

jmhogan commented 3 years ago

@npervan would you mind checking on photon isolation? I was testing some things for electrons and noticed that all the photon isolation values are 0 if I store charged, neutral, photon isolation in the tree.

Either the member functions are null/wrong or the rho is too large/wrong....or maybe just need to test a different sample?

In the end it would be good to store the rho-corrected versions of all 3 branches. The "photon isolation" means "isolation w.r.t other photons" rather than some type of "combined isolation"

npervan commented 3 years ago

The member functions can be seen here so I think they should be fine unless there is some reason that "setPflowIsolationVariables" is not done on data.

If you let me know what sample you're looking at I can try checking these values and the rhos to see what is causing all the isolation values to be zero. I'll also make the change to save all 3 isolation branches.

jmhogan commented 3 years ago

@npervan I just ran the default data file that we have in the config.

npervan commented 3 years ago

Made pull request

caredg commented 2 years ago

Closed with #53