cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Improve PR test reporting #51

Open makortel opened 6 years ago

makortel commented 6 years ago

It would be useful if the PR test reports would note if the PR introduces any changes in the DQM files wrt. the baseline ("development").

cmsbot commented 6 years ago

A new Issue was created by @makortel Matti Kortelainen.

can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

makortel commented 6 years ago

One possibility is to use the "alternative-comparisons" scripts. I use the following adaptation in my private tests

#!/bin/bash

f1=${1}
f2=${2}
fO=${3}
lMod=${4}
dOpt=${5}
dirPattern=${6}
if [ ! -e compareValHists.C ]; then
    wget https://raw.githubusercontent.com/slava77/cms-reco-tools/master/compareValHists.C
fi
echo -e "gROOT->SetStyle(\"Plain\");\n 
 .L compareValHists.C+ \n\
 f1=new TFile(\"${f1}\");\n f2 = new TFile(\"${f2}\");\n compareAll(f1,f2,${lMod},${dOpt}, \"${dirPattern}\");\n\
.qqqqqq" | root -l -b
# add this to manually set the flags, not needed in most cases
# gSystem->SetMakeSharedLib(\"cd \$BuildDir ;g++  -c \$Opt -pipe -m64 -Wshadow -Wall -W -Woverloaded-virtual -fPIC -std=c++11 -Wno-deprecated-declarations -DG__MAXSTRUCT=36000 -DG__MAXTYPEDEF=36000 -DG__LONGLINE=4096 -pthread \$IncludePath \$SourceFiles ; g++ \$ObjectFiles -shared -Wl,-soname,\$LibName.so -m64 -Wl,--hash-style=gnu -O2  \$LinkedLibs -o \$SharedLib\");\n 
mv diff.ps ${fO}
fOPDF=`echo ${fO} | sed -e 's/.ps$/.pdf/g' `
[ -f "diff.pdf" ] &&  mv diff.pdf ${fOPDF} #&& gzip ${fOPDF}

In addition of producing PDF+PS files of changed histograms, it prints their paths. Maybe grepping the output could be sufficient for our case?