search

cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Updating RelVal WF & customisation on CPU #549

Closed AdrianoDee closed 4 years ago

AdrianoDee commented 4 years ago
AdrianoDee commented 4 years ago

Validation summary

Reference release CMSSW_11_2_0_pre5 at 86caca1fddb1 Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at 0c377ca56a12 Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png zoom-136.885502.png scan-136.885512.png zoom-136.885512.png scan-136.885522.png zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/16e762af4b07ea49b08a9477eb79808d50c8a908/log .

mmusich commented 4 years ago

Hi @AdrianoDee May I ask what's the rationale to have 2 customization functions:

? Thanks.

AdrianoDee commented 4 years ago

Hi @mmusich , in principle I think one could have only customizePixeTracksSoAonCPUForWF. I don't know if we want to keep customizePixeTracksSoAonCPU in order to run the full chain independently of siPixelRecHitsPreSplitting being there or not.

Even though this should be extended to pixelTracks and pixelVertices too to be consistent.

fwyzard commented 4 years ago

@AdrianoDee do you foresee adding also equivalent workflows for data ? E.g. 136.885505 and 136.885506

In case, a separate PR is fine, of course.

AdrianoDee commented 4 years ago

Validation summary

Reference release CMSSW_11_2_0_pre7 at 396662cba761 Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at 23bb1aca8d9b Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png zoom-136.885502.png scan-136.885512.png zoom-136.885512.png scan-136.885522.png zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/34ab0b51760eff256084e7aa8006aff36a27607c/log .

AdrianoDee commented 4 years ago

@AdrianoDee do you foresee adding also equivalent workflows for data ? E.g. 136.885505 and 136.885506

In case, a separate PR is fine, of course.

@fwyzard Indeed, yes. I'll do a separate PR

fwyzard commented 4 years ago

I just run into a strange error with this PR:

src/RecoPixelVertexing/Configuration/python/customizePixelTracksSoAonCPU.py:3: SyntaxWarning: import * only allowed at module level
  def customizePixelTracksSoAonCPU(process):
fwyzard commented 4 years ago

@AdrianoDee could you re-run the validation (with the CPU-GPU comparison) after the latest fixes ?

Could you add the new triplet workflows as well ?

AdrianoDee commented 4 years ago

Validation summary

Reference release CMSSW_11_2_0_pre7 at 396662cba761 Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at f50f7a1d4ec8 Testing PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Validation plots (GPU vs CPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW
/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW
/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png zoom-136.885502.png scan-136.885512.png zoom-136.885512.png scan-136.885522.png zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre3-PU_112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre3-112X_mcRun3_2021_realistic_v5-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/6c8e5b4e8fc058b9cf07d177ff46cd9d6ad5a900/log .

AdrianoDee commented 4 years ago

Caveat: 506 & 505 are defined only for testing so the comparisons across releases are not there (and I forgot to add 506 to memchecks).

fwyzard commented 4 years ago

Thanks, looks good :-)