Address HCAL review comments regarding CondFormats/HcalObjects

[mariadalfonso]

as part of review of https://github.com/cms-sw/cmssw/pull/31720

[abdoulline]

Thank you, Maria! Also would like to explicitly add Igor @igv4321

[fwyzard]

Validation summary

Reference release CMSSW_11_2_0_pre8 at 3c9bd1ba78ad Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at 6c2a63380102 Testing branch cms-patatrack/CMSSW_11_2_X_Patatrack at 6c2a63380102 with PRs:

• 565 at e948c4926ac2

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :x: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/68fd64ff1a572a5efce15eee5f4fcb46ea283c78/log .

[fwyzard]

No changes in the HCAL (or other) workflows, as expected.

[fwyzard]

I will do it for the Patatrack PR. Can you do it for the one for CMSSW ?

[mariadalfonso]

I will do it for the Patatrack PR. Can you do it for the one for CMSSW ?

uhm, the only PR I own (13/N) contains only the conditions for the CondFormats/HcalObjects, I didn't push there the files CUDADataFormats/HcalDigi

so both the patatrack and cms-sw (8/N) are yours

[fwyzard]

Ah, perfect, then I'll propagate the change myself with the next update.