cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Remove Pilot Blade from GPU code #581

Closed tvami closed 3 years ago

tvami commented 3 years ago

PR description:

Removing (unused) Pilot Blade related code from SiPixelRawToClusterCUDA.cc. There doesn't seem to be any other occurrence of the Pilot Blade in other (non-CPU) codes.

Original comment: https://github.com/cms-sw/cmssw/pull/31721#discussion_r527608986

PR validation:

The code compiles. Although I get this (unrelated) warning:

****WARNING: Invalid tool RecoTracker/SpecialSeedGenerators. Please fix src/RecoTracker/TkSeedGenerator/plugins/BuildFile.xml file.

fwyzard commented 3 years ago

@tvami I cannot merge branches based on patatrack_integration_9_N_pixel_local_reco in the CMSSW_11_2_X_Patatrack branch, that generates too many conflicts.

I can cherry-pick, squash and merge this one by hand - the changes are simple enough. If you submit other PRs, please start from the CMSSW_11_2_X_Patatrack branch !

Thanks, .Andrea

fwyzard commented 3 years ago

Sorry, I mis-read the branch information... my mistake.

Making a PR from a branche based on patatrack_integration_9_N_pixel_local_reco for patatrack_integration_9_N_pixel_local_reco is fine.