cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Rename SiPixelFedCablingMapGPU to SiPixelROCsStatusAndMapping #582

Closed fwyzard closed 3 years ago

fwyzard commented 3 years ago

Rename SiPixelFedCablingMapGPU to SiPixelROCsStatusAndMapping, and move it from RecoLocalTracker/SiPixelClusterizer/ to

Includes the changes from #578 .

fwyzard commented 3 years ago

Validation summary

Reference release CMSSW_11_2_0_pre10 at 6c149b2963ee Development branch cms-patatrack/master at 47423b3df7e0 Testing branch cms-patatrack/master at 47423b3df7e0 with PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png zoom-136.885502.png scan-136.885512.png zoom-136.885512.png scan-136.885522.png zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/d8dbb2d891279ba8a1bb7f8510787236998e8880/log .

fwyzard commented 3 years ago

No impact on physics, as expected.

The drop in throughput is suspicious, as it also affects ECAL and HCAL that are independent from these changes.

fwyzard commented 3 years ago

I've rerun the profiling by hand:

configuration master with #582
quadruplets 1131.3 ± 2.3 ev/s 1136.2 ± 4.1 ev/s
triplets 671.9 ± 1.3 ev/s 672.4 ± 1.1 ev/s

So, no effects on the throughput either, as expected.