Simplify cudacompat layer to use a 1-dimensional grid

[fwyzard]

Remove the possibility of changing the grid size used by the cms::cudacompat layer, and make it a constant equal to {1, 1, 1}.

This avoids a thread-related problem caused by TBB using worker threads where the grid size had not been initialised.

The kernel for pixel clustering need to be rewritten to support a one-dimensional grid to run on the CPU. Currently they are only used on the GPU in the Patatrack workflows, but they are exercised on the CPU by the gpuClustering_t tests; those tests have been commented out until the kernels can be updated.

[fwyzard]

Validation summary

Reference release CMSSW_11_2_0_pre10 at 6c149b2963ee Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at e454ee04f69a Testing branch cms-patatrack/CMSSW_11_2_X_Patatrack at e454ee04f69a with PRs:

• 586 at 9a6fe7d9efc6

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :x: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :x: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/6fb888134e1c0c96596810e45bca76019e19f734/log .

[fwyzard]

Should fix #564

[VinInn]

if compiles and run the code is ok with me. CPU workflows may even go faster w/o TLS

[fwyzard]

All crashes in the CPU workflows are indeed fixed.

No changes to the physics performance or throughput, as expected.