search

cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Make the the size of the binner (HistoContainer) settable at run time #590

Closed VinInn closed 3 years ago

VinInn commented 3 years ago

This is "step1&2" and makes LocalReco independent from the size of the event and tuple-making independent of the number of hits. Some of the containers used by the CA will remain of fixed size (cannot be extended during the pattern recognition).

In a third step phase1 and phase2 will be still kept separate (fixed number of modules, separate geometries etc) even if fully configurable at runtime.

tested. no regression. even timing seems ok.

fwyzard commented 3 years ago

Validation summary

Reference release CMSSW_11_2_0_pre10 at 6c149b2963ee Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at 6a192beda960 Testing branch cms-patatrack/CMSSW_11_2_X_Patatrack at 6a192beda960 with PRs:

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

scan-136.885502.png zoom-136.885502.png scan-136.885512.png zoom-136.885512.png scan-136.885522.png zoom-136.885522.png

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre7-PU_112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v2/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0_pre7-112X_mcRun3_2021_realistic_v8-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/f0b035cd5ebf1d0372e3031f613521c3257647a8/log .

VinInn commented 3 years ago

I can remove all occurrences of MaxNumberOfHits MaxNumberOfClusters now or later.

VinInn commented 3 years ago

@fwyzard: could you please force-push (or whatever needed to merge this in cmssw)? thanks.

fwyzard commented 3 years ago

Rebased onto CMSSW_11_3_X and moved to https://github.com/cms-sw/cmssw/pull/33371 .