Implement comments for Patatrack integration - ECAL local reconstruction (7/N) #31719

[thomreis]

PR description:

[WIP] Implements the comments of https://github.com/cms-sw/cmssw/pull/31719 I will add more commits to this but wanted to make the a PR already to make the current status already available in case we want to add certain commits already to https://github.com/cms-sw/cmssw/pull/31719 now.

• Removes commented out code
• Removes unused header files
• Migrates to esConsumes
• Adds comments for documentation
• Introduces better variable names
• Copies parameterSets instead of storing a const ref
• Removes unused function
• Moves __syncthreads() outside of the if blocks to avoid blocked threads
• Replaces ecal::abs() with std::abs()
• Removes unused function eigen_solve_submatrix()

PR validation:

• Code compiles
• Tested on gpu-c2a02-39-01.cms with

  cmsDriver.py step3  --conditions auto:phase1_2021_realistic -n 100 --era Run3 --eventcontent RECOSIM,DQM --procModifiers gpu -s RAW2DIGI:RawToDigi_ecalOnly,RECO:reconstruction_ecalOnly,VALIDATION:@ecalOnlyValidation,DQM:@ecalOnly --datatier GEN-SIM-RECO,DQMIO --geometry DB:Extended --no_exec

  Data from /gpu_data/store/mc/RunIIAutumn18DR/TTToHadronic_TuneCP5_13TeV-powheg-pythia8/. Also including PR #592 .

[thomreis]

Do you mean the changes in the last commit or all of them in this PR?

[fwyzard]

Do you mean the changes in the last commit or all of them in this PR?

I saw a commit about Move __syncthreads() out of the if blocks. but now I don't see those changes any more ?

[fwyzard]

... but I do see them now, so I guess I was just looking at something wrong on my side.