Clean up the pixel local reconstruction code

[fwyzard]

Address the pixel local reconstruction review comments:

• remove obsolete comments;
• consistently use named constants;
• rename data members and methods to be more descriptive;
• rename local variables according to the coding rules and for consistency with cms-sw#32591;
• update transient dictionaries to match data types.

[fwyzard]

Validation summary

Reference release CMSSW_11_2_0 at ed6756427f50 Development branch cms-patatrack/CMSSW_11_2_X_Patatrack at 5da727018f89 Testing branch cms-patatrack/CMSSW_11_2_X_Patatrack at 5da727018f89 with PRs:

• 602 at 9a42341490fb

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0_pre11-PU_112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

/RelValZEE_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0_pre11-PU_112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZMM_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZEE_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0_pre11-PU_112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0_pre11-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.512
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :x: cuda-memcheck --tool synccheck (report, log) found no CUDA-MEMCHECK results
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/8921e06dd848b11dbc1ddda98e6253df1e74e934/log .