search

cms-patatrack / cmssw

CMSSW fork of the Patatrack project
https://patatrack.web.cern.ch/patatrack/index.html
Apache License 2.0
2 stars 5 forks source link

Refactor GPU clustering thresholds #608

Closed czangela closed 3 years ago

czangela commented 3 years ago

PR description:

An effort to reduce dedicated namespaces and to introduce more consistency. see #32483 cms-sw

For more information see the commit names.

fwyzard commented 3 years ago

@czangela could you target the PRs to the CMSSW_11_3_X_Patatrack branch ?

The master branch is often unstable (currently it tracks CMSSW_11_3_0_pre4, while CMSSW_11_3_X_Patatrack is still on CMSSW_11_3_0_pre3).

I've changed the target for his one.

fwyzard commented 3 years ago

Validation summary

Reference release CMSSW_11_3_0_pre3 at 3220826ed091 Development branch cms-patatrack/CMSSW_11_3_X_Patatrack at 0972c2f697d2

:construction: Validation running at fu-c2a02-35-03:/data/user/fwyzard/patatrack/validation/run_608.c0ZqwRHPLW ...

czangela commented 3 years ago

@czangela could you target the PRs to the CMSSW_11_3_X_Patatrack branch ?

The master branch is often unstable (currently it tracks CMSSW_11_3_0_pre4, while CMSSW_11_3_X_Patatrack is still on CMSSW_11_3_0_pre3).

I've changed the target for his one.

Will keep this in mind, and thank you. :)

mmusich commented 3 years ago

HI @czangela @fwyzard I have a question about the workflow. In principle these changes could be applied to cms-sw/cmssw as well now that PR https://github.com/cms-sw/cmssw/pull/31721 is merged. How do you wish to proceed for updates? Will someone from the patatrack team propose the changes to cms-sw/cmssw after they are validated here, or should we be doing the synching? I see some other subsystems proposing changes directly to cms-sw/cmssw. Thank you!

fwyzard commented 3 years ago

You are correct, but the problem is that some of the changes affect the pixel track and vertex reconstruction, which are not merged upstream yet.

Once they are tested in this branch, either Angela or myself can make a PR with only the pixel local reco part for cms-sw/cmssw.

Eventually, when the Patatrack branch is fully merged upstream, we can stop making PRs here.

mmusich commented 3 years ago

some of the changes affect the pixel track and vertex reconstruction

right (sigh). I overlooked that. This complicates also the validation procedure if we have to propose changes to algorithms... hopefully when it comes to that the tracking / vertexing part is merged.

czangela commented 3 years ago

Validation summary

Reference release CMSSW_11_3_0_pre3 at 3220826ed091 Development branch cms-patatrack/CMSSW_11_3_X_Patatrack at 0972c2f697d2

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

Logs

The full log is available at https://aczirkos.web.cern.ch/aczirkos/validation/pulls/ea56bfaf068d2ab12b1c2149734e3f2f20dcf7eb/log

fwyzard commented 3 years ago

thanks @czangela - did the validation script run out of the box, or did it need any updates ?