Clean up the pixel vertex reconstruction code

[ericcano]

PR description:

This PR will implement remarks for https://github.com/cms-sw/cmssw/pull/31723.

PR validation:

The baseline and new code will be run through TTbar validations:

• 501: CPU - Quad+Pentaplets

• 502: GPU - Quad+Pentaplets

  • 505: CPU - Trips+Quads+Penta
• 506: GPU - Trips+Quads+Penta

[fwyzard]

Validation summary

Reference release CMSSW_11_3_0_pre5 at 23fad57b764b Development branch cms-patatrack/CMSSW_11_3_X_Patatrack at 16a08d0c7c36 Testing branch cms-patatrack/CMSSW_11_3_X_Patatrack at 16a08d0c7c36 with PRs:

• 609 at f578a16b6a65

Validation plots

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.506

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.506

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflow 11634.5
• tracking validation plots and summary for workflow 11634.501
• tracking validation plots and summary for workflow 11634.505
• tracking validation plots and summary for workflow 11634.502
• tracking validation plots and summary for workflow 11634.506

Validation plots (CPU vs GPU)

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• tracking validation plots and summary for workflows 11634.502 and 11634.501
• tracking validation plots and summary for workflows 11634.506 and 11634.505

Throughput plots

/EphemeralHLTPhysics1/Run2018D-v1/RAW run=323775 lumi=53

logs and nvprof/nvvp profiles

/RelValTTbar_14TeV/CMSSW_11_2_0-PU_112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :x: step3.py: log
• development release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :x: step3.py: log
• testing release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZMM_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v14-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :x: step3.py: log
• development release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :x: cuda-memcheck --tool initcheck (report, log) found no CUDA-MEMCHECK results
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :x: step3.py: log
• testing release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

/RelValZEE_14/CMSSW_11_2_0-112X_mcRun3_2021_realistic_v13-v1/GEN-SIM-DIGI-RAW

• reference release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 11634.511
  • :x: step3.py: log
• development release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• development release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• development release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• development release, workflow 136.885502
• development release, workflow 136.885512
• development release, workflow 136.885522
• testing release, workflow 11634.5
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.501
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.505
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.502
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.506
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 11634.511
  • :x: step3.py: log
• testing release, workflow 11634.512
  • :x: step3.py: log
  • :x: profile.py: log, profile and summary are missing, see the full log for more information
  • :warning: cuda-memcheck --tool initcheck did not run
  • :warning: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all did not run
  • :warning: cuda-memcheck --tool synccheck did not run
• testing release, workflow 11634.521
  • :heavy_check_mark: step3.py: log
• testing release, workflow 11634.522
  • :heavy_check_mark: step3.py: log
  • :heavy_check_mark: profile.py: log
  • :heavy_check_mark: cuda-memcheck --tool initcheck (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool memcheck --leak-check full --report-api-errors all (report, log) did not find any errors
  • :heavy_check_mark: cuda-memcheck --tool synccheck (report, log) did not find any errors
• testing release, workflow 136.885502
• testing release, workflow 136.885512
• testing release, workflow 136.885522

Logs

The full log is available at https://patatrack.web.cern.ch/patatrack/validation/pulls/bd52586219a812f8aadab8439d02a9836e6e617b/log .