search

cms-patatrack / pixeltrack-standalone

Standalone Patatrack pixel tracking
Apache License 2.0
17 stars 35 forks source link

Compiler version check fails on Ubuntu #283

Closed markdewing closed 2 years ago

markdewing commented 2 years ago

The compiler version check added in #280 fails on Ubuntu. Symptoms

/bin/sh: 1: 903: not found
Makefile: 19: *** This program requires GCC 8.0 or later, but the current compiler is GCC 9.3.  Stop.

The makefile shell command for the comparison calls out to the default shell. On Ubuntu, that is dash. The comparison uses a bash extension.

Workarounds:

  1. Use SHELL=/bin/bash in the Makefile
  2. Use test rather than (( )) in the comparison
fwyzard commented 2 years ago

@markdewing thank you for reporting this.

Can you check that #284 fixes the issue for you ?

markdewing commented 2 years ago

Yes, #284 fixes the issue on my machine.

fwyzard commented 2 years ago

:+1: