search

cms-patatrack / pixeltrack-standalone

Standalone Patatrack pixel tracking
Apache License 2.0
17 stars 35 forks source link

Update Boost to version 1.78.0 #326

Closed fwyzard closed 2 years ago

fwyzard commented 2 years ago

Building hip and hiptest on CentOS 7 with GCC 9.2 requires Boost 1.78 or later, in order to pick the fix for https://github.com/boostorg/config/issues/392 .

Tested with various versions of ROCm from 4.0.0 to 5.0.1.

fwyzard commented 2 years ago

@makortel is this OK for you ?

By the way, the version of Boost used in CMSSW was recently bumped to 1.78.0, too.

makortel commented 2 years ago

Visually yes, let me recompile bunch of stuff with this.

What about reverting the workaround added in https://github.com/cms-patatrack/pixeltrack-standalone/pull/207, would that be better done here or as a separate PR?

fwyzard commented 2 years ago

I'm just testing that, and if it works I'd do it in a separate PR.

fwyzard commented 2 years ago

Yes, with Boost 1.78.0 it compiles (and runs) fine also after reverting #207.

fwyzard commented 2 years ago

By the way, I'm using the sourceforge.net mirrors to get Boost (e.g. https://sourceforge.net/projects/boost/files/boost/1.78.0/boost_1_78_0.tar.bz2) because the original location times out for me.

And I've mirrored the mirror at /cvmfs/patatrack.cern.ch/externals/src/boost/download/ ...