search

cms-patatrack / pixeltrack-standalone

Standalone Patatrack pixel tracking
Apache License 2.0
17 stars 35 forks source link

[hip] Simplify HIP compilation flags #365

Closed fwyzard closed 2 years ago

fwyzard commented 2 years ago

Looks like CLANG_RESOURCE_DIR and CLANG_RUNTIME_DIR are only used internally, so we don't need to pass them explicitly.

The use of $(ROCM_BASE)/hip/include and $(ROCM_BASE)/hsa/include is not necessary, because they are symlinked to (or from) $(ROCM_BASE)/include, and their use is deprecated in ROCm 5.2.

fwyzard commented 2 years ago

@makortel I've tested the simplified flags building the hip and alpaka back-ends. Let me know if we should check anything else.

makortel commented 2 years ago

Looks visually ok to me, thanks!