search

cms-rntuple-work / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
0 stars 0 forks source link

Removed embedded BaseTagInfo in pat::Jet #7

Closed Dr15Jones closed 11 months ago

Dr15Jones commented 11 months ago

PR description:

The interface to add an embedded object was removed in 2010 and the member data was only kept to read very old files.

PR validation:

Code compiles.

Dr15Jones commented 11 months ago

@nsmith- FYI

nsmith- commented 11 months ago

FYI I need write access to merge this. Also, we should rewind this repo's master to from-CMSSW_14_0_0_pre0 or change the default branch for simplicity (since the PRs all go against that)

makortel commented 11 months ago

FYI I need write access to merge this. Also, we should rewind this repo's master to from-CMSSW_14_0_0_pre0 or change the default branch for simplicity (since the PRs all go against that)

Or maybe to use some other branch in this repo than master to be more clear on what master means?

Dr15Jones commented 11 months ago

I switched to CMSSW_14_0_0_pre0_modified being the default branch. So we should base all work areas on CMSSW_14_0_0_pre0 for now.

Dr15Jones commented 11 months ago

will move to proper branch

nsmith- commented 11 months ago

You can just change the base by editing the PR