search

cms-sw / SCRAM

Software Configuration And Management - CMS internal build tool
Other
10 stars 8 forks source link

Executable name consistency #74

Closed ShamrockLee closed 3 months ago

ShamrockLee commented 3 months ago

When building SCRAM v3 from the source, the executable name (CLI command name) specified in setup.py is SCRAM. However, it is scram in SCRAM v2 and on LXPLUS.

Is it a design choice to choose a different, all-capital command for SCRAM v3, or is it meant to be scram?

https://github.com/cms-sw/SCRAM/blob/662aa639caa52d0ccc931f0ed41f245ad37c9765/setup.py#L267-L270

cmsbuild commented 3 months ago

cms-bot internal usage

cmsbuild commented 3 months ago

A new Issue was created by @ShamrockLee.

@Dr15Jones, @antoniovilela, @makortel, @mandrenguyen, @rappoccio, @sextonkennedy, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

smuzaffar commented 3 months ago

It should be scram and not SCRAM

ShamrockLee commented 3 months ago

Thank you for getting back to me so quickly! I'll send a pull request to correct it.

I'm trying to get the package build scripts included in Nixpkgs and considering the name to identify it. Since the name scram is occupied on PyPI, would cms-scram be a good choice?

smuzaffar commented 3 months ago

would cms-scram be a good choice?

should be fine