search

cms-sw / cms-bot

A few scripts to automate approval / testing process
28 stars 245 forks source link

Remove data workflows from profiling in PRs #2280

Closed jfernan2 closed 4 months ago

jfernan2 commented 4 months ago

It is known[1] that igprof time profiling crashes at step3 (RECO) for data workflows due to an unknown issue with TF in DeepTau ID[2].

To avoid the problem and at least have profilings for MC workflows which are the most interesting in view of the Phase2 SW upgrades, this PR removes data workflows from the test. Besides, profiling scripts used for PR profiling have been recently updated to only monitor up to step3 (RECO) [3] (thanks @gartung !!)

[1] https://github.com/cms-sw/cmssw/issues/43166 [2] https://github.com/cms-sw/cmssw/issues/42444 https://github.com/cms-sw/cmssw/issues/28358 [3] https://github.com/cms-cmpwg/profiling.git

cmsbuild commented 4 months ago

A new Pull Request was created by @jfernan2 for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 4 months ago

cms-bot internal usage

smuzaffar commented 4 months ago

+externals

cmsbuild commented 4 months ago

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)