search

cms-sw / cms-bot

A few scripts to automate approval / testing process
28 stars 245 forks source link

Added @mandrenguyen as new ORP manager #2294

Closed smuzaffar closed 3 months ago

smuzaffar commented 3 months ago

@cms-sw/orp-l2 , this PR adds @mandrenguyen as ORP for CMS offline & Computing @mandrenguyen , once merged, you will become owner of cms-sw , cms-data and cms-externals github organization. This will allow you to directly push changes to any repository under these organizations. As you are also L2 of reconstruction so simple +1 on PR will sign that PR for both reconstruction and orp. I would suggest to use +reconstruction and +orp to separately sign PRs.

cmsbuild commented 3 months ago

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 3 months ago

cms-bot internal usage

antoniovilela commented 3 months ago

@cms-sw/orp-l2 , this PR adds @mandrenguyen as ORP for CMS offline & Computing @mandrenguyen , once merged, you will become owner of cms-sw , cms-data and cms-externals github organization. This will allow you to directly push changes to any repository under these organizations. As you are also L2 of reconstruction so simple +1 on PR will sign that PR for both reconstruction and orp. I would suggest to use +reconstruction and +orp to separately sign PRs.

Thanks Shahzad! Should we also add 'operations' to Matthew's list?

cmsbuild commented 3 months ago

Pull request #2294 was updated.

smuzaffar commented 3 months ago

Thanks Shahzad! Should we also add 'operations' to Matthew's list?

added now

antoniovilela commented 3 months ago

Thanks Shahzad! Should we also add 'operations' to Matthew's list?

added now

Thanks!

antoniovilela commented 3 months ago

+1

antoniovilela commented 3 months ago

@smuzaffar Would you like to merge, or should I?

smuzaffar commented 3 months ago

+externals

cmsbuild commented 3 months ago

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests.