search

cms-sw / cms-bot

A few scripts to automate approval / testing process
28 stars 245 forks source link

avoid duplication in l2 list #2342

Closed kpedro88 closed 2 months ago

kpedro88 commented 2 months ago

I noticed in https://github.com/cms-sw/cmssw/issues/46113 that the list of tagged L2s could contain duplicates when multiple categories are assigned.

I chose the most broadly compatible approach (works across Python 2 and 3) to remove the duplicates, preserving the order to be as consistent as possible with previous behavior. Tested in standalone Python and it works as expected.

cmsbuild commented 2 months ago

A new Pull Request was created by @kpedro88 for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 2 months ago

cms-bot internal usage

cmsbuild commented 2 months ago

Pull request #2342 was updated.

cmsbuild commented 2 months ago

Pull request #2342 was updated.

cmsbuild commented 2 months ago

Pull request #2342 was updated.

kpedro88 commented 2 months ago

@smuzaffar I updated a test input file manually because I had a failed workflow run from https://github.com/cms-sw/cms-bot/blob/master/.github/workflows/test-process-pr.yaml. However, updating the input file doesn't trigger the workflow and it can't be dispatched manually, so I can't confirm it's fixed. I also don't know if tests/ReplayData should be similarly updated.

smuzaffar commented 2 months ago

+externals

cmsbuild commented 2 months ago

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)