cms-sw / cms-bot

A few scripts to automate approval / testing process
28 stars 245 forks source link

PR Testing: check for warnings also in files not directly touched by PR #2361

Closed iarspider closed 2 weeks ago

iarspider commented 1 month ago

As suggested here: https://github.com/cms-sw/cmssw/pull/46388#issuecomment-2421667896

cmsbuild commented 1 month ago

A new Pull Request was created by @iarspider for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 1 month ago

Pull request #2361 was updated.

cmsbuild commented 4 weeks ago

Pull request #2361 was updated.

cmsbuild commented 4 weeks ago

Pull request #2361 was updated.

cmsbuild commented 4 weeks ago

Pull request #2361 was updated.

cmsbuild commented 3 weeks ago

Pull request #2361 was updated.

iarspider commented 3 weeks ago

@smuzaffar this PR is ready.

smuzaffar commented 3 weeks ago

test parameters:

smuzaffar commented 3 weeks ago

please test

cmsbuild commented 3 weeks ago

Pull request #2361 was updated.

cmsbuild commented 3 weeks ago

Pull request #2361 was updated.

iarspider commented 3 weeks ago

please test

cmsbuild commented 3 weeks ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42578/summary.html COMMIT: 824db824842ec382f438181995b76efce3f1178d CMSSW: CMSSW_14_2_X_2024-11-04-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2361/42578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

iarspider commented 3 weeks ago

please test

cmsbuild commented 3 weeks ago

Pull request #2361 was updated.

cmsbuild commented 3 weeks ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42662/summary.html COMMIT: dc3c9a6455d6c0df53504fd44c7f672a9b23f402 CMSSW: CMSSW_14_2_X_2024-11-07-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2361/42662/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

cmsbuild commented 2 weeks ago

Pull request #2361 was updated.

iarspider commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

Pull request #2361 was updated.

iarspider commented 2 weeks ago

please test

cmsbuild commented 2 weeks ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42725/summary.html COMMIT: 35925f50f14617be3fd8362b9f7b4e480723eacb CMSSW: CMSSW_14_2_X_2024-11-11-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2361/42725/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 2 weeks ago

please test for CMSSW_10_6_X

iarspider commented 2 weeks ago

please test for CMSSW_10_6_X

cmsbuild commented 2 weeks ago

Pull request #2361 was updated.

iarspider commented 2 weeks ago

please test for CMSSW_10_6_X

cmsbuild commented 2 weeks ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-922446/42813/summary.html COMMIT: e5ca10ab64c514c0b1d5af64d8c05d766e6c9ede CMSSW: CMSSW_10_6_X_2024-11-10-0000/slc7_amd64_gcc700 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-bot/2361/42813/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 2 weeks ago

+externals

looks good

cmsbuild commented 2 weeks ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @mandrenguyen, @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

smuzaffar commented 2 weeks ago

@iarspider , looks like this broke the Pr tests. The static checks are running scram b clean which basically deletes allthe generated products. We need to either revert this or need a quick fix

smuzaffar commented 1 week ago

@iarspider , we need to fix this