Adding python quality checks to CMSSW (https://github.com/cms-sw/cms-bot/pull/2319/ follow-up)

cms-sw / cms-bot

A few scripts to automate approval / testing process

28 stars 245 forks source link

Adding python quality checks to CMSSW (https://github.com/cms-sw/cms-bot/pull/2319/ follow-up) #2378

Open aandvalenzuela opened 1 week ago

aandvalenzuela commented 1 week ago

Changes proposed in https://github.com/cms-sw/cms-bot/pull/2319/ needed rebasing

cmsbuild commented 1 week ago

A new Pull Request was created by @aandvalenzuela for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 1 week ago

cms-bot internal usage

cmsbuild commented 1 week ago

Pull request #2378 was updated.

aandvalenzuela commented 1 week ago

This changes are only supposed to be merged once we agree on a Python formatting tool since it will process all touched *.py files in a PR. Discussion for Ruff formatting can be found at https://github.com/cms-sw/cmssw/issues/45706.

After @Benedikttk's summer project, the conclusion was not to use Ruff as a formatting tool due to the lack of customization options. Google's YAPF was proposed as the next tool to be evaluated.