search

cms-sw / cms-bot

A few scripts to automate approval / testing process
28 stars 245 forks source link

Run scram build commands under /usr/bin/time #2380

Closed smuzaffar closed 1 week ago

smuzaffar commented 1 week ago

test parameters:

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

A new Pull Request was created by @smuzaffar for branch master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 1 week ago

cms-bot internal usage

smuzaffar commented 1 week ago

@makortel , this runs scram build under /usr/bin/time see logs https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854405/42991/build.log . Should I add a should message in PR summary comment about the compilation time ?

smuzaffar commented 1 week ago

please test

cmsbuild commented 1 week ago

Pull request #2380 was updated.

makortel commented 1 week ago

Is it this printout?

    Command being timed: "scram b -v -k -j 16"
    User time (seconds): 2174.57
    System time (seconds): 435.37
    Percent of CPU this job got: 1365%
    Elapsed (wall clock) time (h:mm:ss or m:ss): 3:11.17
    Average shared text size (kbytes): 0
    Average unshared data size (kbytes): 0
    Average stack size (kbytes): 0
    Average total size (kbytes): 0
    Maximum resident set size (kbytes): 998052
    Average resident set size (kbytes): 0
    Major (requiring I/O) page faults: 10255
    Minor (reclaiming a frame) page faults: 79924363
    Voluntary context switches: 2068017
    Involuntary context switches: 3297393
    Swaps: 0
    File system inputs: 0
    File system outputs: 2887392
    Socket messages sent: 0
    Socket messages received: 0
    Signals delivered: 0
    Page size (bytes): 4096
    Exit status: 0

This printout is much more extensive than what I've usually seen with /usr/bin/time :)

Should I add a should message in PR summary comment about the compilation time ?

I'm not sure. My feeling is that it is not generally useful for the PR review itself, but could be informative. So I don't think it is really necessary (at this point), but I'm not against of including it.

cmsbuild commented 1 week ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-854405/42992/summary.html COMMIT: 31430cbdf8843188227fc664303f5603107d8a1c CMSSW: CMSSW_14_2_X_2024-11-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cms-bot/2380/42992/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 1 week ago

Is it this printout?

yes, this is with /usr/bin/time -v

smuzaffar commented 1 week ago

+externals

cmsbuild commented 1 week ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)