cms-sw / cms-docker

Docker files for various cms services and tasks
18 stars 29 forks source link

[EL8 CLEANUP] Add docker runtime image and config file #195

Closed aandvalenzuela closed 1 year ago

aandvalenzuela commented 1 year ago

Adding apptainer to runtime image due to https://github.com/aandvalenzuela/cmssw-driver-files/blob/main/images/Dockerfile.runtime#L32

cmsbuild commented 1 year ago

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @rappoccio you are the release manager for this. cms-bot commands are listed here

smuzaffar commented 1 year ago

why not just add it under el8 folder?

aandvalenzuela commented 1 year ago

I was not sure if modifying config.yaml will impact the current jobs for el8

smuzaffar commented 1 year ago

it will but only for new container e.g. just add the following group (which will hopefully built cmssw/el8:x86_64-runtime container)

  runtime:
    docker: Dockerfile.${group0}
    from: library/almalinux:8
    variables:
      SKIP_TESTS: true
    groups:
      x86_64:
        tags:
          ${group1}-${group0}:

once its works then we should remove the SKIP_TESTS and add a test for running cmssw/short runtheMatrix for this container

aandvalenzuela commented 1 year ago

it will but only for new container e.g. just add the following group (which will hopefully built cmssw/el8:x86_64-runtime container)

  runtime:
    docker: Dockerfile.${group0}
    from: library/almalinux:8
    variables:
      SKIP_TESTS: true
    groups:
      x86_64:
        tags:
          ${group1}-${group0}:

once its works then we should remove the SKIP_TESTS and add a test for running cmssw/short runtheMatrix for this container

Right, I forgot about this part of our discussion. My bad!

cmsbuild commented 1 year ago

Pull request #195 was updated.

cmsbuild commented 1 year ago

Pull request #195 was updated.

cmsbuild commented 1 year ago

Pull request #195 was updated.

cmsbuild commented 1 year ago

Pull request #195 was updated.

aandvalenzuela commented 1 year ago

please test

smuzaffar commented 1 year ago

I do not see bot running the tests. let merge and force built the runtime container