cms-sw / cms-docker

Docker files for various cms services and tasks
18 stars 29 forks source link

Skip building cmssw in case of runtime image when testing a new image #200

Closed aandvalenzuela closed 1 year ago

aandvalenzuela commented 1 year ago

It goes with the following job configuration: https://cmssdt.cern.ch/jenkins/job/cms-containers-run-cmssw-test/configure

cmsbuild commented 1 year ago

A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @rappoccio you are the release manager for this. cms-bot commands are listed here

smuzaffar commented 1 year ago

@aandvalenzuela , looks like the runtime images are really only runtime i.e. one can use it to run preinstalled cmssw. Can you please check what packages are required if we want to use it to install cmssw too?

smuzaffar commented 1 year ago

thinking about it again, if we want runtime images to also support installation then we have to add all the packages which we have in bootstrap seed (which are a lot). I would suggest to add a new test for runtime images which actually use cmssw installation from cvmfs i.e. the test should not do any local cmssw installation but should use releases from cvmfs , create dev area and run short matrix and add on tests

cmsbuild commented 1 year ago

Pull request #200 was updated.

aandvalenzuela commented 1 year ago

I have tested the script for the runtime image at https://cmssdt.cern.ch/jenkins/job/test-cmssw-images/19/ and for a regular image at https://cmssdt.cern.ch/jenkins/job/test-cmssw-images/20/ (I will delete the job once this PR is merged since this script will run on the regular https://cmssdt.cern.ch/jenkins/job/cms-containers-run-cmssw-test/ job)

smuzaffar commented 1 year ago

tests looks good

cmsbuild commented 1 year ago

Pull request #200 was updated.

aandvalenzuela commented 1 year ago

Thanks @smuzaffar!

smuzaffar commented 1 year ago

looks good. do you plan to change it more or should we merge it?

aandvalenzuela commented 1 year ago

We can merge it! :)