Closed aandvalenzuela closed 5 months ago
A new Pull Request was created by @aandvalenzuela (Andrea Valenzuela) for branch master.
@aandvalenzuela, @smuzaffar, @cmsbuild, @iarspider can you please review it and eventually sign? Thanks. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this. cms-bot commands are listed here
cms-bot internal usage
Pull request #256 was updated.
Pull request #256 was updated.
Pull request #256 was updated.
Pull request #256 was updated.
Pull request #256 was updated.
Pull request #256 was updated.
Thanks @smuzaffar! It builds locally, should I modify the others in a follow-up PRs? Otherwise we will trigger rebuilds for all of the images, I think
@aandvalenzuela , with this change , you have to make sure that code section https://github.com/cms-sw/cms-docker/blob/master/bin/get_image_config.py#L140-L145 also work. This code reads the file pointed by ADD or COPY
command and include it in checksum. Currently it assumes that file exists under repo directory. So you need to add the concept of build_context
in the config.yaml. Default should be .
and amla8/config.yaml can set it to ..
and then above mention code can make use of it to read the ADD/COPY
files contents
Pull request #256 was updated.
Pull request #256 was updated.
@smuzaffar, I would like to reuse the
rpm-pkg-info.sh
script in all config files, can I put it one level up and get the repo name usingbasename
?