search

cms-sw / cms-docker

Docker files for various cms services and tasks
18 stars 29 forks source link

Fix dockerhub sync and docker tag cleanup jobs #280

Closed aandvalenzuela closed 3 months ago

aandvalenzuela commented 3 months ago

Dump response.text in case response is not a json object to workaround server error.

Fixes https://cmssdt.cern.ch/jenkins/job/dockerhub_synchronization/ and https://cmssdt.cern.ch/jenkins/job/cleanup-docker-tags/ jobs when dockerhub cannot logout and returns http 500 server error.

cmsbuild commented 3 months ago

A new Pull Request was created by @aandvalenzuela for branch master.

@smuzaffar, @iarspider, @aandvalenzuela, @cmsbuild can you please review it and eventually sign? Thanks. @rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 3 months ago

cms-bot internal usage

smuzaffar commented 3 months ago

Also, do we really need this logout() call? why not just remove it?

aandvalenzuela commented 3 months ago

Right, removing it works as well. I did not remove it because I could not find any deprecation or change in the documentation.

smuzaffar commented 3 months ago

I think when we started this then there was no api documentation for docker hub. We just see what docker hub was doing and just converted those to our api implementation :-)

aandvalenzuela commented 3 months ago

Ahh I see :) Let me remove the call then!

cmsbuild commented 3 months ago

Pull request #280 was updated.

smuzaffar commented 3 months ago

@aandvalenzuela , please also cleanup the script to avoid doing from docker_utils import logout

cmsbuild commented 3 months ago

Pull request #280 was updated.