search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

Get default protocol from git config #104

Closed kpedro88 closed 5 years ago

kpedro88 commented 5 years ago

I have noticed that fetching cmssw from GitHub over https is hanging with increasing frequency.

Rather than remember to use the --ssh flag every time, I have updated all the relevant commands to take the default access protocol from the user's global .gitconfig, if available. (If unavailable, the old default is used.)

I have specified the protocol selection should go in a new "cms" section of the .gitconfig, to avoid conflicts with any other settings.

I also noticed there was no man page for git-cms-init, so I added one, with a note about the .gitconfig protocol setting.

cmsbuild commented 5 years ago

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. cms-bot commands are listed here

cmsbuild commented 5 years ago

Pull request #104 was updated.

kpedro88 commented 5 years ago

@fwyzard good idea, I added a check for unsupported values.

smuzaffar commented 5 years ago

please test

cmsbuild commented 5 years ago

The tests are being triggered in jenkins. https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/533/console Started: 2019/05/27 15:57

cmsbuild commented 5 years ago

-1

Tested at: 4e5325e5c63b09374ce96f1047ad5c122e6a2a4c

You can see the results of the tests here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d10bd/533/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

When I ran the RelVals I found an error in the following workflows: 1325.7 step2

runTheMatrix-results/1325.7_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2/step2_TTbar_13_94Xv2NanoAODINPUT+TTbar_13_94Xv2NanoAODINPUT+NANOEDMMC2017_94XMiniAODv2+HARVESTNANOAODMC2017_94XMiniAODv2.log
10824.0 step6 
runTheMatrix-results/10824.0_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018/step6_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018.log
cmsbuild commented 5 years ago

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

smuzaffar commented 5 years ago

please test

cmsbuild commented 5 years ago

The tests are being triggered in jenkins. https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/548/console Started: 2019/05/28 08:07

cmsbuild commented 5 years ago

+1 Tested at: 4e5325e5c63b09374ce96f1047ad5c122e6a2a4c https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d10bd/548/summary.html

cmsbuild commented 5 years ago

Comparison job queued.

smuzaffar commented 5 years ago

+externals

cmsbuild commented 5 years ago

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild commented 5 years ago

Comparison is ready https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0d10bd/548/summary.html

Comparison Summary: