search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

Do not fail if cms.protocol is not set #105

Closed fwyzard closed 5 years ago

cmsbuild commented 5 years ago

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. cms-bot commands are listed here

fwyzard commented 5 years ago

@cmsbuild, please test

cmsbuild commented 5 years ago

The tests are being triggered in jenkins. https://cmssdt.cern.ch/jenkins/job/ib-run-pr-tests/552/console Started: 2019/05/28 16:08

kpedro88 commented 5 years ago

thanks @fwyzard

smuzaffar commented 5 years ago

Thanks @fwyzard , changes look good to me. As I am starting a CXXMODULE IB, so I am merging this and including it in the IB to get this fix deployed on cvmfs.

cmsbuild commented 5 years ago

+1 Tested at: 2e4b9be498d7f2a4114527221e124041439594b2 https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70268f/552/summary.html

cmsbuild commented 5 years ago

Comparison job queued.

cmsbuild commented 5 years ago

Comparison is ready https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-70268f/552/summary.html

Comparison Summary: