search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

Add scripts to fetch or show the content of a pull request #110

Closed fwyzard closed 4 years ago

fwyzard commented 4 years ago

git-cms-fetch-pr

Fetches the pull request to a local branch, named after the PR number

git-cms-show-pr

Shows the commit that compose the pull request

git-cms-cherry-pick-pr

Cherry-picks the commit that compose the pull request

cmsbuild commented 4 years ago

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. cms-bot commands are listed here

smuzaffar commented 4 years ago

@fwyzard , why not use github api https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request to show pull requests commits?

smuzaffar commented 4 years ago

looks like you missed to add git-cms-cherry-pick-pr

cmsbuild commented 4 years ago

Pull request #110 was updated.

fwyzard commented 4 years ago

looks like you missed to add git-cms-cherry-pick-pr

ops, too many branches... should be there now

fwyzard commented 4 years ago

do you think it would be useful to add a -a option to git cms-cherry-pick-pr to call git cms-checkdeps -a ?

fwyzard commented 4 years ago

@fwyzard , why not use github api https://developer.github.com/v3/pulls/#list-commits-on-a-pull-request to show pull requests commits?

That's an interesting idea.

However, it would take me some time to understand how to use it and integrate it in the script, and I don't think I will be able to do any time soon.

So, I would suggest to open an issue to keep track of it, but of course I'd be happy if somebody else steps in to do it :-)

smuzaffar commented 4 years ago

@fwyzard , can you please add the man-pages for these three new commands https://github.com/cms-sw/cms-git-tools/tree/master/docs/man/man1 ?