search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

git cms-checkdeps tool rewritten in python #114

Closed tulamor closed 4 years ago

cmsbuild commented 4 years ago

A new Pull Request was created by @tulamor (Roman) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @tulamor can you please review it and eventually sign? Thanks. cms-bot commands are listed here

smuzaffar commented 4 years ago

@tulamor , looks like it is not working if one moves a file e.g

git mv FWCore/Framework/src/Run.cc FWCore/Framework/src/RunXXXX.cc
git-cms-checkdeps -A
Traceback (most recent call last):
  File "/afs/cern.ch/user/m/muzaffar/git-cms-checkdeps", line 164, in <module>
    stdout = pipe_3.communicate()[0].splitlines()
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/subprocess.py", line 475, in communicate
    stdout = _eintr_retry_call(self.stdout.read)
  File "/cvmfs/cms.cern.ch/slc7_amd64_gcc820/external/python/2.7.15-bcolbf2/lib/python2.7/subprocess.py", line 125, in _eintr_retry_call
    return func(*args)
ValueError: I/O operation on closed file
cmsbuild commented 4 years ago

Pull request #114 was updated.

cmsbuild commented 4 years ago

Pull request #114 was updated.

cmsbuild commented 4 years ago

Pull request #114 was updated.

cmsbuild commented 4 years ago

Pull request #114 was updated.