search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

bug fix: ignore only those packs which exactly match the change set #119

Closed smuzaffar closed 3 years ago

smuzaffar commented 3 years ago

fixes cms-sw/cmssw#33781 git-cms-checkdeps does not checkout package SubX/PackB if a file SubA/PackA/*/file.h ( which is used by SubX/PackB/*/*) is changed along with file *SubX/PackB*/*/* . There was a check which was ignoring files from package SubX/PackB.

In case of https://github.com/cms-sw/cmssw/pull/33783, L1Trigger/L1TMuon was not checkout because of L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc

cmsbuild commented 3 years ago

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch master.

@cmsbuild, @smuzaffar, @mrodozov, @iarspider can you please review it and eventually sign? Thanks. cms-bot commands are listed here

smuzaffar commented 3 years ago

please test with https://github.com/cms-sw/cmssw/pull/33783

smuzaffar commented 3 years ago

this has fixed [a] the issue and properly checkout the L1Trigger/L1TMuon package

[a]

+ git cms-checkdeps -A -a
>> Checking DataFormats/CSCDigi CMSSW_12_0_X_2021-05-18-2300
   x DataFormats/CSCDigi/interface/CSCCLCTDigi.h
   x DataFormats/CSCDigi/interface/CSCCorrelatedLCTDigi.h
   x DataFormats/CSCDigi/interface/CSCShowerDigi.h
   x DataFormats/CSCDigi/src/CSCCLCTDigi.cc
   x DataFormats/CSCDigi/src/CSCCorrelatedLCTDigi.cc
   x DataFormats/CSCDigi/src/CSCShowerDigi.cc
   x DataFormats/CSCDigi/src/classes_def.xml
>> Checking DataFormats/L1CSCTrackFinder CMSSW_12_0_X_2021-05-18-2300
   x DataFormats/L1CSCTrackFinder/src/classes_def.xml
>> Checking L1Trigger/CSCTriggerPrimitives CMSSW_12_0_X_2021-05-18-2300
   x L1Trigger/CSCTriggerPrimitives/src/CSCMotherboard.cc
>> Checking L1Trigger/L1TMuonEndCap CMSSW_12_0_X_2021-05-18-2300
   x L1Trigger/L1TMuonEndCap/src/SectorProcessorShower.cc
Checking out these packages: 52
Calibration/EcalAlCaRecoProducers (header)
Calibration/HcalAlCaRecoProducers (header)
Calibration/HcalIsolatedTrackReco (header)
Calibration/IsolatedParticles (header)
CaloOnlineTools/EcalTools (header)
Configuration/Skimming (header)
DPGAnalysis/Skims (header)
DQM/CSCMonitorModule (header)
DQM/L1TMonitor (header)
DQM/Physics (header)
DQMOffline/JetMET (header)
DQMOffline/Muon (header)
DQMOffline/Trigger (header)
DataFormats/HLTReco (header)
DataFormats/L1TCorrelator (header)
DataFormats/L1TMuon (header)
EventFilter/CSCRawToDigi (header)
EventFilter/CSCTFRawToDigi (header)
EventFilter/L1TRawToDigi (header)
HLTrigger/Egamma (header)
HLTrigger/HLTcore (header)
HLTrigger/HLTfilters (header)
HLTrigger/JetMET (header)
HLTrigger/Muon (header)
HLTrigger/btau (header)
HLTrigger/special (header)
HLTriggerOffline/Egamma (header)
HLTriggerOffline/HeavyFlavor (header)
HLTriggerOffline/Higgs (header)
HLTriggerOffline/JetMET (header)
HLTriggerOffline/Muon (header)
HLTriggerOffline/SUSYBSM (header)
L1Trigger/CSCTrackFinder (header)
L1Trigger/DTTrackFinder (header)
L1Trigger/HardwareValidation (header)
L1Trigger/L1TMuon (header)
L1Trigger/L1TMuonBarrel (header)
L1Trigger/L1TMuonCPPF (header)
L1Trigger/L1TMuonOverlap (header)
L1Trigger/L1TNtuples (header)
cmsbuild commented 3 years ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1e8fee/15190/summary.html COMMIT: 03d15200c968ed5e59af28e16559306b87a795ed CMSSW: CMSSW_12_0_X_2021-05-18-2300/slc7_amd64_gcc900 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cms-git-tools/119/15190/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: