search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

Update git-cms-checkdeps #122

Closed iarspider closed 2 years ago

iarspider commented 2 years ago

Avoid the following error:

Traceback (most recent call last):
File "/data/cmsbld/jenkins/workspace/build-any-ib/w/common/git-cms-checkdeps", line 237, in <module>
if not list(filter(lambda x: recompile==x, packages)):
File "/data/cmsbld/jenkins/workspace/build-any-ib/w/common/git-cms-checkdeps", line 237, in <lambda>
if not list(filter(lambda x: recompile==x, packages)):
NameError: name 'recompile' is not defined
cmsbuild commented 2 years ago

A new Pull Request was created by @iarspider for branch master.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @rappoccio you are the release manager for this. cms-bot commands are listed here

smuzaffar commented 2 years ago

@iarspider , though I have merged this but any idea in which cases this failed and why we have not see this error with cmsdist build? Do you these deps files available. ideally these files should always have dependency with "/" in them.

iarspider commented 2 years ago

The failure doesn't cause the build process to fail, it just logs an exception. I don't remember exactly when I saw this, I was investigating some other failure and saw this error in the (jenkins) log.