search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

handle a missing personal fork on GitHub wih a non-fatal warning #37

Closed fwyzard closed 11 years ago

fwyzard commented 11 years ago

if the user did not fork the CMSSW repository on GitHub, print a non-fatal error message and continue, instead of failing during git fetch

fwyzard commented 11 years ago

Question for @davidlt and @ktf : what should be the "visibility" of the warning ? Right not it's set to be always printed (like the messages about missing configuration setting).

ktf commented 11 years ago

If -q is specified, we should ignore it, IMHO.

fwyzard commented 11 years ago

Hi, actually, both git-cms-init and git-cms-addpkg use "-z" as the short form for "--quiet".

No idea why, this is what I found and kept around. Should I change it to "-q" ?

On 20 August 2013 18:31, Giulio Eulisse notifications@github.com wrote:

If -q is specified, we should ignore it, IMHO.

— Reply to this email directly or view it on GitHubhttps://github.com/cms-sw/cms-git-tools/pull/37#issuecomment-22958142 .

fwyzard commented 11 years ago

Fixed the help message, and made -q/--quiet silence the warning about the missing personal repository

fwyzard commented 11 years ago

Sorry, after actually reading the code, I see that the help message says "-z, --quiet" but the code does check for "-q | --quiet". Will fix the message...

On 20 August 2013 20:12, Andrea Bocci andrea.bocci@cern.ch wrote:

Hi, actually, both git-cms-init and git-cms-addpkg use "-z" as the short form for "--quiet".

No idea why, this is what I found and kept around. Should I change it to "-q" ?

On 20 August 2013 18:31, Giulio Eulisse notifications@github.com wrote:

If -q is specified, we should ignore it, IMHO.

— Reply to this email directly or view it on GitHubhttps://github.com/cms-sw/cms-git-tools/pull/37#issuecomment-22958142 .

ktf commented 11 years ago

No, please fix the code. The old addpkg used -z.

fwyzard commented 11 years ago

...and yet all git commands use -q :-(

On 21 August 2013 09:04, Giulio Eulisse notifications@github.com wrote:

No, please fix the code. The old addpkg used -z.

— Reply to this email directly or view it on GitHubhttps://github.com/cms-sw/cms-git-tools/pull/37#issuecomment-22999076 .

ktf commented 11 years ago

You convinced me, I'll tell that to those who complained. Go ahead.

fwyzard commented 11 years ago

Both -q and -z are supported now :-)

.A

On 21 August 2013 09:39, Giulio Eulisse notifications@github.com wrote:

You convinced me, I'll tell that to those who complained. Go ahead.

— Reply to this email directly or view it on GitHubhttps://github.com/cms-sw/cms-git-tools/pull/37#issuecomment-23000319 .