search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

Check custom remote #48

Closed fwyzard closed 10 years ago

fwyzard commented 10 years ago

check for a custom set "my-cmssw" remote

includes #47

ktf commented 10 years ago

Merging your stuff. I've similar changes in

https://github.com/ktf/cms-git-tools/compare/master...misc-fixes

One thing I do not particularly like is the fact you always fetch changes on git-addpkg. Why not leaving it to an explicit git fetch, now that you have the correct mapping between refs in place?

fwyzard commented 10 years ago

Hi Giulio, I haven't reviews git-cms-addpkg much yet, will do when I have some time ...

.A

fwyzard commented 10 years ago

...OK, since we do not support an explicit "tag", it makes sense to simply drop the fetch.

See #50

.A

fwyzard commented 10 years ago

Also, this ( #47 ) is checking the wrong remote ("origin", not "my-cmssw") - fixed in #49 .

By the way - it looks like my repository got messed up at some point, GitHub was not showing the difference between #47 and #48, and seems to have lost a branch of mine ...