search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

add trailing slash only if one is already available for sparse-checkout #77

Closed slava77 closed 8 years ago

slava77 commented 8 years ago

current version kills possibility to merge-topic changes with non-package structure. A specific example is when using submodules .gitmodules file and the submodule reference do not make it properly to the local copy.

the sed preselection will add the trailing slash for CMSSW packages (all have a form of sub/pack), but not for other elements (files or submodule references and such)

cmsbuild commented 8 years ago

A new Pull Request was created by @slava77 (Slava Krutelyov) for branch master.

@cmsbuild, @smuzaffar, @degano, @iahmad-khan, @davidlange6 can you please review it and eventually sign? Thanks. You can sign-off by replying to this message having '+1' in the first line of your reply. You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#2529

slava77 commented 8 years ago

@smuzaffar, @degano, @iahmad-khan, @davidlange6 any comments or issues here?

cmsbuild commented 8 years ago

Pull request #77 was updated.

external issue cms-sw/cmsdist#2529

smuzaffar commented 8 years ago

thanks.

smuzaffar commented 8 years ago

@iahmad-khan , can you please update https://github.com/cms-sw/cmsdist/blob/IB/CMSSW_8_1_X/gcc530/cms-git-tools.spec to use bc09850960e199431cbf6c5b1e1bc9808775870d commit