search

cms-sw / cms-git-tools

CMS Git Helpers
34 stars 26 forks source link

propagate documentation updates #95

Closed kpedro88 closed 6 years ago

kpedro88 commented 6 years ago

I finally figured out the right way to propagate man page updates here:

I touched all the files (to pull in earlier updates that hadn't been propagated with make) and made a few more fixes.

cmsbuild commented 6 years ago

A new Pull Request was created by @kpedro88 (Kevin Pedro) for branch master.

@cmsbuild, @smuzaffar, @gudrutis, @mrodozov can you please review it and eventually sign? Thanks. You can sign-off by replying to this message having '+1' in the first line of your reply. You can reject by replying to this message having '-1' in the first line of your reply.

external issue cms-sw/cmsdist#3826

smuzaffar commented 6 years ago

@kpedro88 , I do not remember why this was not done with in spec file. I would suggest to drop all the generated files and we run make during build.

cmsbuild commented 6 years ago

Pull request #95 was updated.

external issue cms-sw/cmsdist#3826

kpedro88 commented 6 years ago

@smuzaffar yes, that would make more sense. I updated this PR to remove the generated files, and updated the makefile to create the output dir before trying to fill it (while ignoring it in .gitignore).

cmsbuild commented 6 years ago

Pull request #95 was updated.

external issue cms-sw/cmsdist#3826

kpedro88 commented 6 years ago

can you update the spec file?

smuzaffar commented 6 years ago

spec is updated : https://github.com/cms-sw/cmsdist/pull/3837