search

cms-sw / cmsdist

CMS Offline Software build configuration
Other
27 stars 183 forks source link

Add lwtnn as external dependency #2749

Closed mverzett closed 7 years ago

mverzett commented 7 years ago

Dear admins, The BTV team would like to add a new set of taggers based on deep neural networks. We developed a new set of plugins based on lwtnn which we would like to add as external dependency. This issue follows from issue 17085 of cms-sw/cmssw Few info:

davidlt commented 7 years ago

BOOST_SPIRIT_THREADSAFE is part of default CMS CXXFLAGS thus most likely he has them. Just do scram b -v -k -j <threads>and check the log if you see BOOST_SPIRIT_THREADSAFE.

mverzett commented 7 years ago

@davidlt Even for an external dependency?

smuzaffar commented 7 years ago

I do not think that it was defined for the lwtnn build. I will update the lwtnn spec to define it.

smuzaffar commented 7 years ago

thanks @Dr15Jones for the suggestion. Re-building lwtnn with BOOST_SPIRIT_THREADSAFE fixed the issue. 23h CMSSW_9_0_DEVEL_X IB contains the fix. @mverzett, please try CMSSW_9_0_DEVEL_X_2017-01-16-2300 IB (you do not need to fix lwtnn toolfile any more, it is fixed)

mverzett commented 7 years ago

@smuzaffar , indeed it works! Thanks.

smuzaffar commented 7 years ago

assign externals

smuzaffar commented 7 years ago

+externals

cmsbuild commented 7 years ago

New categories assigned: externals

@smuzaffar,@iahmad-khan you have been requested to review this Pull request/Issue and eventually sign? Thanks

cmsbuild commented 7 years ago

This issue is fully signed and ready to be closed.

smuzaffar commented 7 years ago

this should now be available in normal 90X IBs (starting from CMSSW_9_0_X_2017-01-17-2300)

mverzett commented 7 years ago

Sorry to re-open it. Given that now #17247 has been approved and merged, would it be possible to have lwtnn also in the 80X cycle?

smuzaffar commented 7 years ago

@iahmad-khan , can you please make a backport PR of cms-sw/cmsdist#2773 for 80X?

dguest commented 7 years ago

Wow, I'm the main developer for lwtnn and someone just pointed me to this. I'm glad you've found our software useful! Let me know if you have any problems. In particular the current head should be stable, so if you'd like me to create a release let me know.

mverzett commented 7 years ago

@iahmad-khan , while you are at it, could you also make a PR for 81X, in this way I can include the new tagger in all the cycles from 80X onwards. Thanks!

iahmad-khan commented 7 years ago

@davidlange6 should i port it to 81X?

slava77 commented 7 years ago

On 2/13/17 12:32 AM, Mauro Verzetti wrote:

@iahmad-khan https://github.com/iahmad-khan , while you are at it, could you also make a PR for 81X, in this way I can include the new tagger in all the cycles from 80X onwards. Thanks!

AFAIK, there is no plan to make another 81X release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmsdist/issues/2749#issuecomment-279323291, or mute the thread https://github.com/notifications/unsubscribe-auth/AEdcbpD4KsJQCglqKZ2W7OHvWGl3qDW0ks5rcBU7gaJpZM4LS1rE.