search

cms-sw / cmsdist

CMS Offline Software build configuration
Other
27 stars 180 forks source link

Migrate DD4hep external library to v1-29 #9254

Closed civanch closed 2 months ago

civanch commented 2 months ago

In the recent version of DD4hep an important fix is introduced: order of instantiation of geometry objects is fixed to be stable, no random change of this order anymore. This fix may fix issue cms-sw/cmssw#40205 and guarantees the same order of instantiation of sensitive detectors.

It is possible that this update from v01-27-2 to v1-29 will keep regression - subject of tests. So, I would not exclude of update to this version of DD4hep directly in the master. If there will be problems we may first switch to G4VECGEOM branch.

The page of dd4hep: https://github.com/AIDASoft/DD4hep/blob/master/doc/ReleaseNotes.md

cmsbuild commented 2 months ago

cms-bot internal usage

cmsbuild commented 2 months ago

A new Issue was created by @civanch.

@rappoccio, @Dr15Jones, @sextonkennedy, @makortel, @antoniovilela, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

iarspider commented 2 months ago

@civanch just to clarify: we should first try updating DD4Hep in CMSSW_14_1_X/master branch, but if the tests fail we should first merge it into CMSSW_14_1_X/g4 branch to test it in G4VEGGEOM IBs, right?

civanch commented 2 months ago

@iarspider , yes i suspect that updated library will work with the master.