search

cms-sw / cmsdist

CMS Offline Software build configuration
Other
27 stars 183 forks source link

Add ruff as external #9350

Closed aandvalenzuela closed 2 months ago

aandvalenzuela commented 2 months ago

Required for Python formatting with Ruff

cmsbuild commented 2 months ago

A new Pull Request was created by @aandvalenzuela for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @cmsbuild, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 2 months ago

cms-bot internal usage

aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

Pull request #9350 was updated.

aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

Pull request #9350 was updated.

cmsbuild commented 2 months ago

Pull request #9350 was updated.

cmsbuild commented 2 months ago

Pull request #9350 was updated.

aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb7b1/40786/summary.html COMMIT: 5f99df9a94ce1c723cb56a29b2658a084ea03c7b CMSSW: CMSSW_14_1_X_2024-08-05-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9350/40786/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building: 

+ '[' 0 -ne 0 ']'
+ cd ruff-x86_64-unknown-linux-gnu
+ chmod -Rf a+rX,u+w,g-w,o-w .
+ cp ruff-x86_64-unknown-linux-gnu/ruff /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/2e4021b468cf9a8b980fb015ea6dd468/opt/cmssw/el8_amd64_gcc12/external/ruff/0.5.6-2e4021b468cf9a8b980fb015ea6dd468/bin
cp: cannot stat 'ruff-x86_64-unknown-linux-gnu/ruff': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.duSkJL (%prep)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+ruff+0.5.6-2e4021b468cf9a8b980fb015ea6dd468
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.duSkJL (%prep)
aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

Pull request #9350 was updated.

cmsbuild commented 2 months ago

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb7b1/40790/summary.html COMMIT: 375bbe393820e5b5f4c124898f5e7e23c4c98a64 CMSSW: CMSSW_14_1_X_2024-08-05-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9350/40790/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building: 

+ '[' 0 -ne 0 ']'
+ cd ruff-x86_64-unknown-linux-gnu
+ chmod -Rf a+rX,u+w,g-w,o-w .
+ cp ruff /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/4394e46c7de5a6501bd7f84761ca363e/opt/cmssw/el8_amd64_gcc12/external/ruff/0.5.6-4394e46c7de5a6501bd7f84761ca363e/bin
cp: cannot create regular file '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/BUILDROOT/4394e46c7de5a6501bd7f84761ca363e/opt/cmssw/el8_amd64_gcc12/external/ruff/0.5.6-4394e46c7de5a6501bd7f84761ca363e/bin': No such file or directory
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.rFQIfR (%prep)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+ruff+0.5.6-4394e46c7de5a6501bd7f84761ca363e
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.rFQIfR (%prep)
cmsbuild commented 2 months ago

Pull request #9350 was updated.

aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb7b1/40791/summary.html COMMIT: f5b31a3b7f3695b314f93c73fb4db23b05e1bca2 CMSSW: CMSSW_14_1_X_2024-08-05-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9350/40791/install.sh to create a dev area with all the needed externals and cmssw changes.

External Build

I found compilation error when building: 

+ for x in external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28 .
+ i=/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/./etc/profile.d/init.sh
+ '[' -f /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/./etc/profile.d/init.sh ']'
+ make install
make: *** No rule to make target 'install'.  Stop.
error: Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TvtStN (%install)


RPM build errors:
line 36: It's not recommended to have unversioned Obsoletes: Obsoletes: external+ruff+0.5.6-6bbc92e9f21c11c6e9baf672141bcd2d
Bad exit status from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/tmp/rpm-tmp.TvtStN (%install)
aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

Pull request #9350 was updated.

cmsbuild commented 2 months ago

-1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb7b1/40792/summary.html COMMIT: e302ded960b4e3df42485f5c8beeb62544fdd579 CMSSW: CMSSW_14_1_X_2024-08-05-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9350/40792/install.sh to create a dev area with all the needed externals and cmssw changes.

cmsbuild commented 2 months ago

Pull request #9350 was updated.

aandvalenzuela commented 2 months ago

please test

cmsbuild commented 2 months ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ceb7b1/40794/summary.html COMMIT: 263a008f9ffa0fef65d857a5fe55c1f2b10193e3 CMSSW: CMSSW_14_1_X_2024-08-05-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9350/40794/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary: