search

cms-sw / cmsdist

CMS Offline Software build configuration
Other
27 stars 180 forks source link

do not create symlinks if system gcc is used #9351

Closed smuzaffar closed 1 month ago

smuzaffar commented 1 month ago

Thsi should avoid creating symlinks for /usr/lib/gcc/$(uname -m)-redhat-linux/<version>/plugin if system gcc is used

smuzaffar commented 1 month ago

please test

cmsbuild commented 1 month ago

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_1_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20581/40783/summary.html COMMIT: 9dea5fd2d0fb7e1959bae13ccbf351e2bea478e0 CMSSW: CMSSW_14_1_X_2024-08-05-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9351/40783/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20581/40783/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a20581/40783/git-merge-result

Comparison Summary

Summary:

smuzaffar commented 1 month ago

+externals

cmsbuild commented 1 month ago

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_1_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @mandrenguyen, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)