search

cms-sw / cmsdist

CMS Offline Software build configuration
Other
27 stars 183 forks source link

[rivet] Apply missing header VetoedFinalState.hh change #9413

Closed smuzaffar closed 1 month ago

smuzaffar commented 1 month ago

This should fix the build errors[a] we randomly get while building rivet

[a] https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-009ffd/41616/externals/rivet/4.0.0-57d8f601c3c8a9de147843a10172837f/log

pluginATLAS/ATLAS_2017_I1517194.cc: In member function 'virtual void Rivet::ATLAS_2017_I1517194::init()':
pluginATLAS/ATLAS_2017_I1517194.cc:42:7: error: 'VetoedFinalState' was not declared in this scope
   42 |       VetoedFinalState vfs;
      |       ^~~~~~~~~~~~~~~~
pluginATLAS/ATLAS_2017_I1517194.cc:43:7: error: 'vfs' was not declared in this scope; did you mean 'ffs'?
   43 |       vfs.vetoFinalState(lf);
      |       ^~~
      |       ffs
smuzaffar commented 1 month ago

please test

cmsbuild commented 1 month ago

A new Pull Request was created by @smuzaffar for branch IB/CMSSW_14_2_X/master.

@aandvalenzuela, @iarspider, @smuzaffar can you please review it and eventually sign? Thanks. @antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 1 month ago

cms-bot internal usage

cmsbuild commented 1 month ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-1246eb/41622/summary.html COMMIT: 4d216838b605f6851fff318f949d5199fe523795 CMSSW: CMSSW_14_2_X_2024-09-19-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmsdist/9413/41622/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 1 month ago

+externals

cmsbuild commented 1 month ago

This pull request is fully signed and it will be integrated in one of the next IB/CMSSW_14_2_X/master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @mandrenguyen, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)