search

cms-sw / cmssw-config

CMSSW build configuration
4 stars 14 forks source link

Fix for edm class version check #89

Closed smuzaffar closed 2 years ago

smuzaffar commented 2 years ago

Make sure to fail the build process if EDM Class Version or EDM Class Transients checks fail

cmsbuild commented 2 years ago

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for branch scramv3.

@cmsbuild, @smuzaffar, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @qliphy you are the release manager for this. cms-bot commands are listed here

smuzaffar commented 2 years ago

please test

cmsbuild commented 2 years ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/summary.html COMMIT: bda452df6eef92f8aafda21daed8c46976dc2331 CMSSW: CMSSW_12_3_X_2022-02-14-2300/slc7_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/89/22441/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/git-recent-commits.json https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22441/git-merge-result

Build

I found compilation error when building: 

>> Checking EDM Class Transients in libPhysicsToolsFWLite.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libDataFormatsHLTReco.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libCalibrationHcalCalibAlgos.so
error: class 'pat::Muon' has a different checksum for ClassVersion 29. Increment ClassVersion to 30 and assign it to checksum 4221614933
Suggestion: You can run 'scram build updateclassversion' to generate src/DataFormats/PatCandidates/src/classes_def_objects.xml.generated with updated ClassVersion
>> Checking EDM Class Version for src/DataFormats/PatCandidates/src/classes_def_trigger.xml in libDataFormatsPatCandidates.so
@@@@ ----> OK  EDM Class Version 
>> Checking EDM Class Transients in libPhysicsToolsPatUtils.so
Error in : Dictionary trigger function for DataFormatsPatCandidates_x3r not found
cmsbuild commented 2 years ago

Pull request #89 was updated.

smuzaffar commented 2 years ago

test parameters:

smuzaffar commented 2 years ago

please test

smuzaffar commented 2 years ago

+externals

cmsbuild commented 2 years ago

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2)

cmsbuild commented 2 years ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a74df0/22454/summary.html COMMIT: c7f9d8379dd81452d959e4989c779b9a444a8ee2 CMSSW: CMSSW_12_3_X_2022-02-15-2300/slc7_amd64_gcc10 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/89/22454/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

@slava77 comparisons for the following workflows were not done due to missing matrix map:

Summary: