search

cms-sw / cmssw-config

CMSSW build configuration
4 stars 14 forks source link

Update ROCm static link rules #90

Closed fwyzard closed 1 year ago

fwyzard commented 1 year ago

Update the ROCm build rules to bundle only the device-side libraries, with

objcopy -j '__CLANG_OFFLOAD_BUNDLE*' file.hip.cc.o file.hip.cc.rocm_o`
...
ar crs *.rocm_o archive_rocm.a
cmsbuild commented 1 year ago

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch scramv3.

@cmsbuild, @smuzaffar, @aandvalenzuela, @iarspider can you please review it and eventually sign? Thanks. @perrotta, @dpiparo, @rappoccio you are the release manager for this. cms-bot commands are listed here

fwyzard commented 1 year ago

Ah... you've done it already !

fwyzard commented 1 year ago

And both this version and the one in scramv3 branch work locally.

smuzaffar commented 1 year ago

@fwyzard , I think my changes https://github.com/cms-sw/cmssw-config/commit/d061d7071f0052ea0476dba8860b9d43f3ed96c5 should cover this rule

smuzaffar commented 1 year ago

this has been taken care in V07-05-03 tag

fwyzard commented 1 year ago

Actually V07-05-03 has the changes before the implementation of this rule. Could you tag the latest changes as V07-05-04 and push it to cmssw ?

smuzaffar commented 1 year ago

ah sorry, I have push V07-05-04