search

cms-sw / cmssw-config

CMSSW build configuration
4 stars 14 forks source link

Print the Pass/Fail/Skip messages in color if the output is a terminal #98

Closed fwyzard closed 10 months ago

fwyzard commented 10 months ago

When the output is not a terminal (e.g. a file or a pipe), the output is unchanged: image

When the output is a terminal, the "Pass", "Fail" and "Skip" messages are coloured: image

cmsbuild commented 10 months ago

A new Pull Request was created by @fwyzard (Andrea Bocci) for branch scramv3.

@iarspider, @smuzaffar, @cmsbuild, @aandvalenzuela can you please review it and eventually sign? Thanks. @rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this. cms-bot commands are listed here

cmsbuild commented 10 months ago

cms-bot internal usage

fwyzard commented 10 months ago

please test

smuzaffar commented 10 months ago

test parameters:

smuzaffar commented 10 months ago

please test

lets run tests with few packages checked out

cmsbuild commented 10 months ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36630/summary.html COMMIT: 6c44011fa083878991f687e02c3327100cb53b1b CMSSW: CMSSW_14_0_X_2023-12-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36630/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

fwyzard commented 10 months ago

I think the warning about possibly uninitialised memory are unrelated to these changes ?

/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02816/el8_amd64_gcc12/external/boost/1.80.0-9d4e0dc8cf1f8fc8a67cf53ae917955e/include/boost/graph/detail/adj_list_edge_iterator.hpp:80:13: warning: 'MEM[(struct stored_edge_property * const &)&ei + 48]' may be used uninitialized [-Wmaybe-uninitialized]

and

/data/cmsbld/jenkins/workspace/ib-run-pr-tests/testBuildDir/el8_amd64_gcc12/external/gcc/12.3.1-40d504be6370b5a30e3947a6e575ca28/include/c++/12.3.1/bits/stl_pair.h:535:11: warning: 'modRow' may be used uninitialized [-Wmaybe-uninitialized]
smuzaffar commented 10 months ago

@fwyzard , looks like some other issue. Normal PR tests build.log looks like this where you can find multiple scram build stages but the build log for this PR looks truncated

smuzaffar commented 10 months ago

please test

lets rerun the tests

cmsbuild commented 10 months ago

-1

Failed Tests: Build Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36638/summary.html COMMIT: 6c44011fa083878991f687e02c3327100cb53b1b CMSSW: CMSSW_14_0_X_2023-12-21-1100/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36638/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation warning when building: See details on the summary page.

smuzaffar commented 10 months ago

No idea why build.log gets truncated while running https://github.com/cms-sw/cms-bot/blob/master/pr_testing/test_multiple_prs.sh#L1014

[a]

Copying tmp/el8_amd64_gcc12/src/RecoPPS/Local/src/RecoPPSLocal/libRecoPPSLocal.so to productstore area:
Leaving library rule at RecoPPS/Local
>> Leaving Package RecoPPS/Local
>> Package RecoPPS/Local built
>> Subsystem RecoPPS built
gmake[1]: Entering directory '/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_14_0_X_2023-12-21-1100'
tail: build.log: file truncated
>> Entering Package CalibPPS/ESProducers
>> Leaving Package CalibPPS/ESProducers
>> Package CalibPPS/ESProducers built
fwyzard commented 10 months ago

Ah... I'll try with >> .

cmsbuild commented 10 months ago

Pull request #98 was updated.

fwyzard commented 10 months ago

please test

cmsbuild commented 10 months ago

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f3ab/36648/summary.html COMMIT: 316db38de689cb0162263e91e2dd92d626b7df7f CMSSW: CMSSW_14_0_X_2023-12-21-2300/el8_amd64_gcc12 User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw-config/98/36648/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

smuzaffar commented 10 months ago

+externals

cmsbuild commented 10 months ago

This pull request is fully signed and it will be integrated in one of the next scramv3 IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)