search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.08k stars 4.3k forks source link

undo TrackExtra size increase done in #17367 #17372

Open slava77 opened 7 years ago

slava77 commented 7 years ago

this was done to get 900pre3 going and gives about 10% increase in RECO size. Follow up will need to have some changes in fastsim first.

@VinInn @ssekmen

cmsbuild commented 7 years ago

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

slava77 commented 6 years ago

@VinInn @ssekmen @mdhildreth Are we in position now to advance with this issue?

Recall that the RECO data tier was increased by 10% due to issues in FastSim with PU (#17367)

smuzaffar commented 4 years ago

@slava77 , any update on this?

slava77 commented 4 years ago

adding TRK conveners @mtosi @JanFSchulte

slava77 commented 4 years ago

assign reconstruction,simulation

cmsbuild commented 4 years ago

New categories assigned: reconstruction,simulation

@mdhildreth,@slava77,@perrotta,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

slava77 commented 3 years ago

(to refresh the status) this is still active in a way; there was a recent discussion in connection with #30544 (which remained as an RFC and closed; a more generic variant of #31217, which was merged).

@cms-sw/fastsim-l2

the point here is to make the following data members transient (again)

   TrajParams=vector<LocalTrajectoryParameters> m_trajParams;
   Chi2sFive=vector<uchar> m_chi2sX5;  // chi2 * 5  chopped at 255

To quote a few pieces from the email thread in August 2020 (after we narrowed down that the only use case is apparently in FastTrackDeDxProducer): @slava77 :

My somewhat simplistic understanding of the fastsim use case is that FastTrackDeDxProducer can use propagated ~expected trajectory parameters instead of the actual local trajectory parameters from the fit.

@VinInn :

In very good approximation yes (One can even refit the track starting from the hit (this is done for some DQM module)...): I agree. Not "Fast" though....

slava77 commented 3 years ago

assign fastsim

cmsbuild commented 3 years ago

New categories assigned: fastsim

@mdhildreth,@sbein,@ssekmen,@lveldere,@civanch you have been requested to review this Pull request/Issue and eventually sign? Thanks

slava77 commented 3 years ago

@cms-sw/fastsim-l2 was there a follow up to this?

Please clarify. Thank you.

jpata commented 2 years ago

@cms-sw/fastsim-l2 any update here?

smuzaffar commented 11 months ago

@cms-sw/fastsim-l2 any update?