search

cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.07k stars 4.27k forks source link

HLT DQM #19142

Open mtosi opened 7 years ago

mtosi commented 7 years ago
cmsbuild commented 7 years ago

A new Issue was created by @mtosi mia tosi.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

dmitrijus commented 7 years ago

Hi @mtosi,

where is this code coming from?

+void HTMonitor::bookME(DQMStore::IBooker &ibooker, HTME& me, const std::string& histname, const std::string& histtitle, int nbins, double min, double max)

I've seen it in half of the pull requests listed here. If this comes from some kind of template for HLT module, please turn it into some kind of generic cpp module.

Ironically, one of these modules is actually called 'GENERICDQM'...

mtosi commented 7 years ago

ciao it was in one of mine example for non experts and as you saw almost everybody copied-n-pasted it :( I agree we should have a more general class for doing it mia

On Fri, Jun 23, 2017 at 3:28 PM, Dmitrijus notifications@github.com wrote:

Hi @mtosi https://github.com/mtosi,

where is this code coming from:

+void HTMonitor::bookME(DQMStore::IBooker &ibooker, HTME& me, const std::string& histname, const std::string& histtitle, int nbins, double min, double max)

I've seen it in half of the pull requests listed here. If this comes from some kind of template for HLT module, please turn it into some kind of generic cpp module.

Ironically one of such modules is actually called 'GENERICDQM'

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cms-sw/cmssw/issues/19142#issuecomment-310665114, or mute the thread https://github.com/notifications/unsubscribe-auth/AEt5851T-z5XucKbpWLc9JKd-JeEQDcYks5sG71mgaJpZM4Nz-no .