cms-sw / cmssw

CMS Offline Software
http://cms-sw.github.io/
Apache License 2.0
1.09k stars 4.32k forks source link

provide functionality to count missing hits from inactive [pixel] detectors beyond the extremes of the trajectory #19940

Closed slava77 closed 6 years ago

slava77 commented 7 years ago

19881 has (finally) introduced a check for inactive components "badComponents" during filling the secondary (missing inner and outer) hit patterns, in addition to already available check for the full measurement det inactive.

For pixels a some fraction of inactive dets was set only in the "badComponents" (bad ROCs from SiPixelQualityFromDbRcd). So, analysis/ID selections relying on missing inner hits were inadvertently developed in part by counting actual inactive subdetectors as missing hits.

This issue is to add information to the hitPattern to be able to independently count inactive layers beyond the extremes of the trajectory (saved in the missing_inner and missing_outer parts) and not interfere with the missing hits/layer functionality originally designed to ignore inactive areas.

@arizzi @gpetruc @VinInn @makortel @rovere

cmsbuild commented 7 years ago

A new Issue was created by @slava77 Slava Krutelyov.

@davidlange6, @Dr15Jones, @smuzaffar can you please review it and eventually sign/assign? Thanks.

cms-bot commands are listed here

slava77 commented 7 years ago

assign reconstruction

cmsbuild commented 7 years ago

New categories assigned: reconstruction

@slava77,@perrotta you have been requested to review this Pull request/Issue and eventually sign? Thanks

VinInn commented 7 years ago

Please add "beyond the extremes of the trajectory" Those inside a trajectory are already accounted for. a possibility (somehow backward incompatible) is to add a "hit type" to the MISSING_INNER/OUTER category. This will require some changes to the interface and implementation of HitPattern and most probably major changes in client code (including MiniAOD packing I suspect)

slava77 commented 7 years ago

title and description were updated

VinInn commented 7 years ago

addressed in #20938